cloud-fan commented on a change in pull request #26775: [SPARK-30018][SQL]
Support ALTER DATABASE SET OWNER syntax
URL: https://github.com/apache/spark/pull/26775#discussion_r364594708
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2532,6 +2532,9 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
case (PROP_COMMENT, _) =>
throw new ParseException(s"$PROP_COMMENT is a reserved namespace
property, please use" +
s" the COMMENT clause to specify it.", ctx)
+ case (ownership, _) if ownership == PROP_OWNER_NAME || ownership ==
PROP_OWNER_TYPE =>
+ throw new ParseException(s"$ownership is a reserved namespace
property , please use" +
Review comment:
is `ownership` guaranteed to be upper case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
