gengliangwang commented on a change in pull request #27157:
[SPARK-30428][SQL][FOLLOWUP] File source V2: Push data filters for file listing
URL: https://github.com/apache/spark/pull/27157#discussion_r365010090
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScan.scala
##########
@@ -65,6 +65,16 @@ trait FileScan extends Scan with Batch with
SupportsReportStatistics with Loggin
*/
def withPartitionFilters(partitionFilters: Seq[Expression]): FileScan
+ /**
+ * Returns the filters that can be use for file listing
+ */
+ def dataFilters: Seq[Expression]
Review comment:
It seems too many methods to implement in `FileScan`.
How about just
```
def filters: Seq[Expression]
def withFilters(filters: Seq[Expression]): FileScan
```
And we get the data/partition filters in FileScan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
