Github user maropu commented on the pull request:

    https://github.com/apache/spark/pull/4614#issuecomment-74420544
  
    Understood.
    
    I was thinking that not dummy arguments but the duplicated 'Conf' class in 
SVDPlusPlus
    are used so as to solve the issue;
    
      /** Obsolete: Configuration parameters for SVDPlusPlus. */
      class Conf(
          var rank: Int,
           ....
          var gamma7: Double)
        extends Serializable
    
      /**Configuration parameters for SVDPlusPlus. */
      class SVDPlusPlusConf(
          var rank: Int,
           ....
          var gamma7: Double)
        extends Serializable
    
    --- new
    def run(edges: RDD[Edge[Double]], conf: SVDPlusPlusConf)
    --- obsolete
    def run(edges: RDD[Edge[Double]], conf: Conf)
    
    Thought?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to