kevinyu98 commented on a change in pull request #27130:
[SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with
subdirectories
URL: https://github.com/apache/spark/pull/27130#discussion_r365561742
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala
##########
@@ -170,4 +170,156 @@ class HiveOrcSourceSuite extends OrcSuite with
TestHiveSingleton {
test("SPARK-11412 read and merge orc schemas in parallel") {
testMergeSchemasInParallel(OrcFileOperator.readOrcSchemasInParallel)
}
+
+ test("SPARK-25993 CREATE EXTERNAL TABLE with subdirectories") {
+ Seq(true, false).foreach { convertMetastore =>
+ withSQLConf(HiveUtils.CONVERT_METASTORE_ORC.key -> s"$convertMetastore")
{
+ withTempDir { dir =>
+ try {
+ sql("USE default")
+ sql(
+ """
+ |CREATE EXTERNAL TABLE hive_orc(
Review comment:
@dongjoon-hyun Thanks for pointing out this. I was using other test cases
without thinking too much. I have changed the name. I also replaced the
hiveClient.runSqlHive for the insert stmt.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
