Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/4592#discussion_r24748159
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala ---
@@ -39,13 +39,14 @@ class GroupedData protected[sql](df: DataFrameImpl,
groupingExprs: Seq[Expressio
df.sqlContext, Aggregate(groupingExprs, namedGroupingExprs ++
aggExprs, df.logicalPlan))
}
- private[this] def aggregateNumericColumns(f: Expression => Expression):
Seq[NamedExpression] = {
- df.numericColumns.map { c =>
- val a = f(c)
- Alias(a, a.toString)()
- }
+ private[this] def aggregateNumericColumns(colNames: String*)
--- End diff --
That's good but we are exposing implementation details of df to
GroupedData...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
