prog012 commented on issue #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer URL: https://github.com/apache/spark/pull/27077#issuecomment-573484402 @dongjoon-hyun I can close this PR but I still think this is a defect because it is about optimizer not functionality. The key point here is optimizer should not affect the result of the code. In the example: 1. The result is incorrect with the optimizer (EliminateSorts), the result is changed because of optimizer even though the code in example is not correct logically. 2. The result of the example is correct if I disable or fix the optimizer in EliminateSorts. Maybe a better solution is to give hint on the logical error of the example code, but that is beyond this PR. That's just my two cents.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
