cloud-fan commented on a change in pull request #27174: [SPARK-30490][SQL] Eliminate compiler warnings in Avro datasource URL: https://github.com/apache/spark/pull/27174#discussion_r365771746
########## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala ########## @@ -78,7 +80,17 @@ class AvroOptions( parameters .get(AvroOptions.ignoreExtensionKey) .map(_.toBoolean) - .getOrElse(!ignoreFilesWithoutExtension) + .map { ignoreExtensionOption => + if (ignoreExtensionOption != !ignoreFilesWithoutExtensionByDefault) { + warn(s"The Avro option '${AvroOptions.ignoreExtensionKey}'") Review comment: Yea we shouldn't instantiate twice, but not a big problem. I'm more worried about we instantiate it for every partition. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org