MaxGekk commented on a change in pull request #26973: [SPARK-30323][SQL] Support filters pushdown in CSV datasource URL: https://github.com/apache/spark/pull/26973#discussion_r365789628
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ########## @@ -2204,4 +2204,37 @@ class CSVSuite extends QueryTest with SharedSparkSession with TestCsvData { checkAnswer(resultDF, Row("a", 2, "e", "c")) } } + + test("filters push down") { + Seq(true, false).foreach { multiLine => Review comment: And this is some kind of end-to-end test, I would test as much as possible options and modes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org