mickjermsurawong-stripe commented on a change in pull request #27153:
[SPARK-20384][SQL] Support value class in schema of Dataset (without breaking
existing current projection)
URL: https://github.com/apache/spark/pull/27153#discussion_r366181241
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -679,6 +679,33 @@ class DataFrameSuite extends QueryTest with
SharedSparkSession {
assert(df.schema.map(_.name) === Seq("key", "valueRenamed", "newCol"))
}
+ test("Value class filter") {
+ val df = spark.sparkContext
+ .parallelize(Seq(StringWrapper("a"), StringWrapper("b"),
StringWrapper("c")))
+ .toDF()
+ val filtered = df.where("s = \"a\"")
+ checkAnswer(filtered,
spark.sparkContext.parallelize(Seq(StringWrapper("a"))).toDF)
+ }
+
+ test("Array value class filter") {
+ val ab = ArrayStringWrapper(Seq(StringWrapper("a"), StringWrapper("b")))
+ val cd = ArrayStringWrapper(Seq(StringWrapper("c"), StringWrapper("d")))
+
+ val df = spark.sparkContext.parallelize(Seq(ab, cd)).toDF
+ val filtered = df.where(array_contains(col("wrappers.s"), "b"))
+ checkAnswer(filtered, spark.sparkContext.parallelize(Seq(ab)).toDF)
+ }
+
+ test("Nested value class filter") {
+ val a = ContainerStringWrapper(StringWrapper("a"))
+ val b = ContainerStringWrapper(StringWrapper("b"))
+
+ val df = spark.sparkContext.parallelize(Seq(a, b)).toDF
+ // flat value class, `s` field is not in schema
+ val filtered = df.where("wrapper = \"a\"")
+ checkAnswer(filtered, spark.sparkContext.parallelize(Seq(a)).toDF)
Review comment:
Before this change we never support nested value class:
- Filter with `wrapper` would break with
```
org.apache.spark.sql.AnalysisException: cannot resolve '(`wrapper` = 'a')'
due to data type mismatch: differing types in '(`wrapper` = 'a')'
(struct<s:string> and string).; line 1 pos 0;
```
- Filter with `wrapper.s` would break with:
```
java.lang.ClassCastException: java.lang.String cannot be cast to
org.apache.spark.sql.test.SQLTestData$StringWrapper
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
