vanzin commented on a change in pull request #27208: [SPARK-30481][CORE]
Integrate event log compactor into Spark History Server
URL: https://github.com/apache/spark/pull/27208#discussion_r367137936
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -569,6 +570,35 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
}
}
+ /**
+ * Returns a tuple containing two values. Each element means:
+ * - 1st (Boolean): true if the list of event log files are changed, false
otherwise.
+ * - 2nd (Option[Long]): Some(value) if the method succeeds to try
compaction,
+ * value indicates the last event log index to try compaction. None
otherwise.
Review comment:
what does it mean to "try compaction"? Does it mean that when this method
returns, no compaction was actually done, it was just tried?
The tuple being returned sounds a bit confusing. instead, why not return
just an `Option[Long]` telling you both whether compaction ran, and what's the
index of the first non-compacted file (or last compacted file, not sure what's
being tracked really)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
