Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/4562#discussion_r24793945
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala ---
@@ -287,7 +287,11 @@ case class ParquetRelation2(
}
}
- parquetSchema = maybeSchema.getOrElse(readSchema())
+ try {
+ parquetSchema = readSchema().getOrElse(maybeSchema.get)
+ } catch {
+ case e => throw new SparkException(s"Failed to find schema for
${paths.mkString(",")}", e)
+ }
--- End diff --
After reading the source code, I am wondering if the `maybeMetastoreSchema`
is redundant, and it probably should be always converted into `maybeSchema`
when creating the `ParquetRelation2` instance?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
