cloud-fan commented on a change in pull request #27226: [SPARK-30524] [SQL]
Disable OptimizeSkewedJoin rule when introducing additional shuffle
URL: https://github.com/apache/spark/pull/27226#discussion_r367228040
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -114,25 +120,56 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends
Rule[SparkPlan] {
stage.shuffle.shuffleDependency.rdd.partitions.length
}
- def handleSkewJoin(plan: SparkPlan): SparkPlan = plan.transformUp {
- case smj @ SortMergeJoinExec(leftKeys, rightKeys, joinType, condition,
- s1 @ SortExec(_, _, left: ShuffleQueryStageExec, _),
- s2 @ SortExec(_, _, right: ShuffleQueryStageExec, _))
- if supportedJoinTypes.contains(joinType) =>
+ private def containShuffleQueryStage(plan : SparkPlan): (Boolean,
ShuffleQueryStageExec) =
Review comment:
why not just return `Option[ShuffleQueryStageExec]`? we can rename the
method to `getShuffleQueryStage`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
