yaooqinn commented on a change in pull request #27197: [SPARK-30507][SQL]
TableCalalog reserved properties shoudn't be changed via options or tblpropeties
URL: https://github.com/apache/spark/pull/27197#discussion_r367236529
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -894,6 +895,87 @@ class DataSourceV2SQLSuite
}
}
+ test("create/replace/alter table - reserved properties") {
+ import TableCatalog._
+ withSQLConf((SQLConf.LEGACY_PROPERTY_NON_RESERVED.key, "false")) {
+ RESERVED_PROPERTIES.asScala.filterNot(_ == PROP_COMMENT).foreach { key =>
Review comment:
I suggest we revisit it later, cuz' now we treat `comment` as a special
field like `location` and `provider` in many places. e.g. CTAS/RTAS statement,
DESC commands. Although this change is small, it might change a lot of relative
logic.
FYI, We can do this when we migrate CT/CTAS, etc to new the new plan
resolver.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
