imback82 commented on a change in pull request #27243: [SPARK-30535][SQL]
Migrate ALTER TABLE commands to the new framework
URL: https://github.com/apache/spark/pull/27243#discussion_r367765569
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2916,14 +2916,14 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
* }}}
*/
override def visitAddTableColumns(ctx: AddTableColumnsContext): LogicalPlan
= withOrigin(ctx) {
- AlterTableAddColumnsStatement(
- visitMultipartIdentifier(ctx.multipartIdentifier),
+ AlterTableAddColumns(
+ UnresolvedTable(visitMultipartIdentifier(ctx.multipartIdentifier)),
Review comment:
`UnresolvedTableOrView` wouldn't work since it can resolve to a temp view.
Do you have any suggestion if we need to provide the hint? (btw, the hint is
used only for V1 commands)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
