ajithme commented on a change in pull request #27039: [SPARK-29174][SQL] Support LOCAL in INSERT OVERWRITE DIRECTORY to data source URL: https://github.com/apache/spark/pull/27039#discussion_r367787286
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ########## @@ -809,7 +805,12 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder(conf) { } if (!path.isEmpty) { - val customLocation = Some(CatalogUtils.stringToURI(path)) + val customLocation = if (ctx.LOCAL() != null) { + // force scheme to be file rather than fs.default.name Review comment: @HyukjinKwon Can i update the PR instead to follow Hive behavior i.e if a non local scheme is mentioned, the command fails.? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org