Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/2851#discussion_r24840983
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -522,7 +523,9 @@ private[spark] class BlockManagerInfo(
logInfo("Removed %s on %s on tachyon (size: %s)".format(
blockId, blockManagerId.hostPort,
Utils.bytesToString(blockStatus.tachyonSize)))
}
+ return BlockStatus(storageLevel, 0, 0, 0)
}
+ null
--- End diff --
actually the code should not enter into this line...unless something wrong
happened in updating
https://github.com/CodingCat/spark/blob/SPARK-3957/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala#L457
maybe I can change
https://github.com/CodingCat/spark/blob/SPARK-3957/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala#L373
to an Option, or add a if guard in
https://github.com/CodingCat/spark/blob/SPARK-3957/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala#L373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
