cloud-fan commented on a change in pull request #27262: [SPARK-30551][SQL] Disable comparison for interval type URL: https://github.com/apache/spark/pull/27262#discussion_r367904015
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala ########## @@ -296,14 +296,11 @@ private[columnar] final class BinaryColumnStats extends ColumnStats { } private[columnar] final class IntervalColumnStats extends ColumnStats { - protected var upper: CalendarInterval = CalendarInterval.MIN_VALUE - protected var lower: CalendarInterval = CalendarInterval.MAX_VALUE + protected var upper: CalendarInterval = null + protected var lower: CalendarInterval = null Review comment: can we follow `BinaryColumnStats` and don't define the `upper` and `lower` variable? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org