attilapiros commented on a change in pull request #27257: [SPARK-30540][Web UI]
HistoryServer application link is incorrect when one application having
multiple attempts
URL: https://github.com/apache/spark/pull/27257#discussion_r367905080
##########
File path: core/src/main/resources/org/apache/spark/ui/static/historypage.js
##########
@@ -140,7 +140,8 @@ $(document).ready(function() {
(attempt.hasOwnProperty("attemptId") ? attempt["attemptId"] + "/"
: "") + "logs";
attempt["durationMillisec"] = attempt["duration"];
attempt["duration"] = formatDuration(attempt["duration"]);
- var app_clone = {"id" : id, "name" : name, "version": version, "num"
: num, "attempts" : [attempt]};
+ var app_clone = {"id" : id, "name" : name, "version": version, "num"
: num, "attempts" : [attempt],
Review comment:
As I see as you introduced the `attemptId` instead of `num` now in the
`historypage-template.html` there is no more usage of the `num` property (view
data property). If it is not used can you please delete it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
