cloud-fan commented on a change in pull request #27253: [SPARK-30524] [SQL]
follow up SPARK-30524 to resolve comments
URL: https://github.com/apache/spark/pull/27253#discussion_r367906482
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -222,6 +203,8 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends
Rule[SparkPlan] {
case shuffleStage: ShuffleQueryStageExec if shuffleStage.id ==
left.id ||
shuffleStage.id == right.id =>
PartialShuffleReaderExec(shuffleStage, skewedPartitions.toSet)
+ case sort: SortMergeJoinExec =>
Review comment:
let's make it future proof (more than 1 SMJ on the plan) :
```
case smj @ SortMergeJoinExec(_, _, _, _,
s1 @ SortExec(_, _, l: ShuffleQueryStageExec, _),
s2 @ SortExec(_, _, r: ShuffleQueryStageExec, _), _) if l.id == left.id
&& r.id == right.id =>
smj.copy(
left = s1.copy(child = PartialShuffleReaderExec(l,
skewedPartitions.toSet)),
right = s2.copy(child = PartialShuffleReaderExec(r,
skewedPartitions.toSet)),
isPartial = true)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
