huaxingao commented on a change in pull request #27254:
[SPARK-30543][ML][PYSPARK][R] RandomForest add Param bootstrap to control
sampling method
URL: https://github.com/apache/spark/pull/27254#discussion_r368090999
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
##########
@@ -147,6 +151,7 @@ class RandomForestClassifier @Since("1.4.0") (
val instances = extractInstances(dataset, numClasses)
val strategy =
super.getOldStrategy(categoricalFeatures, numClasses,
OldAlgo.Classification, getOldImpurity)
+ strategy.bootstrap = $(bootstrap)
instr.logParams(this, labelCol, featuresCol, weightCol, predictionCol,
probabilityCol,
rawPredictionCol, leafCol, impurity, numTrees, featureSubsetStrategy,
maxDepth, maxBins,
Review comment:
Do we need to log ```bootstrap``` too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
