cloud-fan commented on a change in pull request #27243: [SPARK-30535][SQL]
Migrate ALTER TABLE commands to the new framework
URL: https://github.com/apache/spark/pull/27243#discussion_r368401698
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -86,6 +87,20 @@ trait CheckAnalysis extends PredicateHelper {
}
def checkAnalysis(plan: LogicalPlan): Unit = {
+ // Analysis that needs to be performed top down can be added here.
+ plan.foreach {
+ case p if p.analyzed => // Skip already analyzed sub-plans
+
+ case alter: AlterTable =>
+ alter.table match {
+ case u @ UnresolvedTableWithViewExists(view) if !view.isTempView =>
Review comment:
shall we use the same error message as permanent views?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
