Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/4650#issuecomment-74879414
Please add tests for your RDF loader, and see my codes as an example:
https://github.com/maropu/spark/commit/cc5ac0b08ca39c3c339fdca905779bb3b037f8fa
BTW, I think that it'd would be better to divide an interface and the
implementations
for GraphLoader because we'll possibly add the some types of GraphLoader
for different formats in a future.
e.g.,)
- an interface
o.a.spark.graphx.GraphLoader:
abstract class GraphLoader {
def edgeListFile(...)
}
- the implementations
o.a.spark.graphx.impl.loader.LineLoader
class LineLoader extends GraphLoader {
def edgeListFile() = {the current implementation of
GraphLoader#edgeListFile}
}
o.a.spark.graphx.impl.loader.RDFLoader
class RDFLoader extends GraphLoader {
def edgeListFile() = {your codes}
}
Thought?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
