BryanCutler commented on a change in pull request #27165:
[SPARK-28264][PYTHON][SQL] Support type hints in pandas UDF and rename/move
inconsistent pandas UDF types
URL: https://github.com/apache/spark/pull/27165#discussion_r368763300
##########
File path: python/pyspark/sql/udf.py
##########
@@ -135,41 +102,43 @@ def returnType(self):
to_arrow_type(self._returnType_placeholder)
except TypeError:
raise NotImplementedError(
- "Invalid returnType with scalar Pandas UDFs: %s is "
+ "Invalid return type with scalar Pandas UDFs: %s is "
"not supported" % str(self._returnType_placeholder))
elif self.evalType == PythonEvalType.SQL_GROUPED_MAP_PANDAS_UDF:
if isinstance(self._returnType_placeholder, StructType):
try:
to_arrow_type(self._returnType_placeholder)
except TypeError:
raise NotImplementedError(
- "Invalid returnType with grouped map Pandas UDFs: "
- "%s is not supported" %
str(self._returnType_placeholder))
+ "Invalid return type with grouped map Pandas UDFs or"
Review comment:
does this need a trailing space `or"` -> `or "`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
