maropu commented on a change in pull request #27058: [SPARK-30276][SQL] Support
Filter expression allows simultaneous use of DISTINCT
URL: https://github.com/apache/spark/pull/27058#discussion_r368807776
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala
##########
@@ -331,6 +472,14 @@ object RewriteDistinctAggregates extends
Rule[LogicalPlan] {
}
}
+ private def collectAggregateExprs(a: Aggregate): Seq[AggregateExpression] = {
Review comment:
nit:
```
private def collectAggregateExprs(a: Aggregate): Seq[AggregateExpression]
= {
a.aggregateExpressions.flatMap { _.collect {
case ae: AggregateExpression => ae
}}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
