cloud-fan commented on a change in pull request #27300: [SPARK-30591][SQL]
Remove the nonstandard SET OWNER syntax for namespaces
URL: https://github.com/apache/spark/pull/27300#discussion_r368810513
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2533,13 +2533,10 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
throw new ParseException(s"$PROP_LOCATION is a reserved namespace
property, please use" +
s" the LOCATION clause to specify it.", ctx)
case (PROP_LOCATION, _) => false
- case (ownership, _) if ownership == PROP_OWNER_NAME || ownership ==
PROP_OWNER_TYPE =>
- if (legacyOn) {
- false
- } else {
- throw new ParseException(s"$ownership is a reserved namespace
property , please use" +
- " ALTER NAMESPACE ... SET OWNER ... to specify it.", ctx)
- }
+ case (PROP_OWNER, _) if !legacyOn =>
+ throw new ParseException(s"$PROP_OWNER is a reserved namespace
property, it will be" +
+ s" set to the current user by default.", ctx)
Review comment:
"by default"? It can only be the current user, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
