cloud-fan commented on a change in pull request #27293:
[SPARK-29938][SQL][FOLLOW-UP] Improve AlterTableAddPartitionCommand
URL: https://github.com/apache/spark/pull/27293#discussion_r369121734
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala
##########
@@ -137,6 +136,47 @@ object CommandUtils extends Logging {
size
}
+ def calculateLocationsSizes(
+ sparkSession: SparkSession,
+ tid: TableIdentifier,
+ paths: Seq[Option[URI]]): Seq[Long] = {
Review comment:
do we need to return a Seq[Long]? both the caller sides only need the sum.
If we return sum, we can simplify
https://github.com/apache/spark/pull/27293/files#diff-cc5307336e7e0368b17c94d8dd7afe41R168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
