attilapiros commented on issue #27257: [SPARK-30540][WEBUI] HistoryServer 
application link is incorrect when one application having multiple attempts
URL: https://github.com/apache/spark/pull/27257#issuecomment-577635908
 
 
   Your change must be tested with the missing attemptID and see whether that 
default value is fine.
   We can use the git annotate to find the PR which introduced the checking of 
the property existence.
   
   Here is the PR: https://github.com/apache/spark/pull/17795
   
   As I see 
   ```
   {
     "id" : "application_1467878474947_0048",
     "name" : "Spark shell",
     "attempts" : [ {
       "startTime" : "2016-12-30T03:22:47.300GMT",
       "endTime" : "2016-12-30T03:33:42.460GMT",
       "lastUpdated" : "2017-04-27T14:02:35.282GMT",
       "duration" : 655160,
       "sparkUser" : "spark",
       "completed" : true,
       "startTimeEpoch" : 1483068167300,
       "endTimeEpoch" : 1483068822460,
       "lastUpdatedEpoch" : 1493301755282
     } ]
   }
   ```
   was a spark shell. 
   Please run a test where spark shell was started (another idea to check the 
eventlogs used as a resource file for testing). 
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to