Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2765#discussion_r25066151
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/api/java/JavaStreamingContext.scala
---
@@ -204,9 +204,10 @@ class JavaStreamingContext(val ssc: StreamingContext)
extends Closeable {
* monitored directory by "moving" them from another location within the
same
* file system. File names starting with . are ignored.
* @param directory HDFS directory to monitor for new file
+ * @param depth Searching depth of directory
*/
- def textFileStream(directory: String): JavaDStream[String] = {
- ssc.textFileStream(directory)
+ def textFileStream(directory: String, depth: Int = 1):
JavaDStream[String] = {
--- End diff --
This won't work for Java API compatibility, I think. I think we need two
methods, one of which has a non-optional new depth param.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
