Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4027#discussion_r25096773
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -63,20 +63,25 @@ private[spark] class CoarseMesosSchedulerBackend(
// Maximum number of cores to acquire (TODO: we'll need more flexible
controls here)
val maxCores = conf.get("spark.cores.max", Int.MaxValue.toString).toInt
+ val maxExecutorsPerSlave =
conf.getInt("spark.mesos.coarse.executors.max", 1)
+ val maxCpusPerExecutor = conf.getInt("spark.mesos.coarse.cores.max",
Int.MaxValue)
--- End diff --
the name of this value is very confusing. Say I'm a new user to Spark on
Mesos and I see both `spark.cores.max` and `spark.mesos.coarse.cores.max`.
Which one do I set, do I set both? Does one override the other?
I think a better name for this is probably
`spark.mesos.coarse.coresPerExecutor`. It's a little more verbose, but there's
no opportunity for ambiguity with this name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
