MaxGekk commented on a change in pull request #27438: [MINOR][SQL][DOCS][2.4]
Fix the timestamp pattern in the example for `to_timestamp`
URL: https://github.com/apache/spark/pull/27438#discussion_r374207683
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -2967,7 +2967,7 @@ object functions {
* See [[java.text.SimpleDateFormat]] for valid date and time format patterns
*
* @param s A date, timestamp or string. If a string, the data must be in
a format that can be
- * cast to a timestamp, such as `yyyy-MM-dd` or `yyyy-MM-dd
HH:mm:ss.SSSS`
Review comment:
@cloud-fan I tried to document the restriction of `to_timestmp()` in the PR
but @dongjoon-hyun convinced me to do not do that here, see
https://github.com/apache/spark/pull/27438#issuecomment-581262355 " I believe
that one thing we need is that yyyy-MM-dd HH:mm:ss.SSSS -> yyyy-MM-dd HH:mm:ss
change. I recommend to focus on the above change only."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
