Github user shivaram commented on the pull request:

    https://github.com/apache/spark/pull/4583#issuecomment-75397427
  
    Sorry I got caught up with some other stuff for the past couple of days. 
@florianverhein my recommendation is hopefully not arbitrary but just that if 
we take in a directory as an argument to `--deploy-root-dir` then its nicer to 
keep the directory at the destination as well. As you said this is the behavior 
that rsync supports without a trailing `/` and this is the behavior we support 
in spark-ec2's `copy-dir` as well. 
    
    FWIW I don't think there are any right or wrong choices here and this is 
mostly a question of behavior that will seem most natural to users. It'll be 
great to hear what other EC2 users like @nchammas or @JoshRosen feel about this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to