Github user alanctgardner commented on a diff in the pull request:
https://github.com/apache/spark/pull/3626#discussion_r25172516
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -65,6 +66,25 @@ class NaiveBayesModel private[mllib] (
override def predict(testData: Vector): Double = {
labels(brzArgmax(brzPi + brzTheta * testData.toBreeze))
}
+
+ def classProbabilities(testData: RDD[Vector]):
--- End diff --
Sorry for the delay, I have no strong preference but "predictProbabilities"
makes sense for consistency. I can make that change and the style ones
mentioned.
My stats background is not super-strong, @jatinpreet seemed to imply
there's a correctness issue with this PR. Can anyone comment on if I've got the
math wrong?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
