viirya commented on a change in pull request #27499: [SPARK-30590][SQL] Untyped
select API cannot take typed column expression
URL: https://github.com/apache/spark/pull/27499#discussion_r376738792
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -352,8 +352,7 @@ object functions {
* @group agg_funcs
* @since 1.3.0
*/
- def count(columnName: String): TypedColumn[Any, Long] =
- count(Column(columnName)).as(ExpressionEncoder[Long]())
+ def count(columnName: String): Column = count(Column(columnName))
Review comment:
This seems to me it is wrongly being a `TypedColumn`. `Count` is a
`DeclarativeAggregate`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
