dongjoon-hyun commented on a change in pull request #27562: [SPARK-30811][SQL][BRANCH-2.4] CTE should not cause stack overflow when it refers to non-existent table with same name URL: https://github.com/apache/spark/pull/27562#discussion_r379024955
########## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ########## @@ -2641,4 +2641,12 @@ class DataFrameSuite extends QueryTest with SharedSQLContext { val idTuples = sampled.collect().map(row => row.getLong(0) -> row.getLong(1)) assert(idTuples.length == idTuples.toSet.size) } + + test("SPARK-30811: CTE should not cause stack overflow when " + Review comment: Can we have a unit test in `AnalysisErrorSuite` in `sql/catalyst` instead of this test suite in `sql/core`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org