WinkerDu commented on a change in pull request #26971: [SPARK-30320][SQL] Fix 
insert overwrite to DataSource table with dynamic partition error
URL: https://github.com/apache/spark/pull/26971#discussion_r379874760
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -1521,4 +1521,10 @@ package object config {
     .bytesConf(ByteUnit.BYTE)
     .createOptional
 
+  private[spark] val MAX_LOCAL_TASK_FAILURES = 
ConfigBuilder("spark.task.local.maxFailures")
+    .doc("The max failure times for a task while SparkContext running in Local 
mode, " +
 
 Review comment:
   In UT class InsertWithMultipleTaskAttemptSuite, I don't expect launching 
speculative task in local mode. Actually, I make a customized commit protocol 
named "InsertExceptionCommitProtocol" in InsertWithMultipleTaskAttemptSuite, 
which overriding commitTask method to fail the first commit task on purpose and 
restore to normal in subsequent commit tasks. This scene is similar to what 
happened in speculative tasks with failure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to