Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3205#discussion_r25329334
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala ---
@@ -108,13 +108,12 @@ private[spark] class ExecutorRunner(
}
/** Replace variables such as {{EXECUTOR_ID}} and {{CORES}} in a command
argument passed to us */
- def substituteVariables(argument: String): String = argument match {
--- End diff --
Of course, I don't mean you would have substitutions for values that don't
exist. It would be different between the two. The driver only supports two
substitutions now. I suppose I mean I like that you improved the logic to allow
substituting these placeholders *within* arguments. That would be nice to have
both places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
