Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4178#issuecomment-75948201
@prabeesh eh OK you mean you addressed that comment? I still am not sure
that the comment from @dragos was addressed as I mentioned before. But since
that `catch` block was already there, may not matter much. The cleanup is minor
and in a part of code unlikely to be hit by merge conflicts. I think the
benefit is really slightly better resource management in this example, and
handling a full queue. I'll merge soon if nobody objects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
