Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4747#discussion_r25365970
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala 
---
    @@ -345,11 +345,11 @@ private[spark] class Worker(
               }
     
               // Create local dirs for the executor. These are passed to the 
executor via the
    -          // SPARK_LOCAL_DIRS environment variable, and deleted by the 
Worker when the
    +          // SPARK_EXECUTOR_DIRS environment variable, and deleted by the 
Worker when the
               // application finishes.
               val appLocalDirs = appDirectories.get(appId).getOrElse {
                 Utils.getOrCreateLocalRootDirs(conf).map { dir =>
    -              Utils.createDirectory(dir).getAbsolutePath()
    +              Utils.createDirectory(dir, namePrefix = 
"executor").getAbsolutePath()
    --- End diff --
    
    Not needed (see SPARK-4834). That's done by the `maybeCleanupApplication` 
in this file when the application finishes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to