Eric5553 commented on a change in pull request #27595: [SPARK-30842][SQL]
Adjust abstraction structure for join operators
URL: https://github.com/apache/spark/pull/27595#discussion_r380216709
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/CartesianProductExec.scala
##########
@@ -60,23 +61,13 @@ class UnsafeCartesianRDD(
case class CartesianProductExec(
left: SparkPlan,
right: SparkPlan,
- condition: Option[Expression]) extends BinaryExecNode {
+ joinType: JoinType,
Review comment:
Thanks for review! Addressed in 4397ce88a99b4777067e7a636f12e22612b04be5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
