Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4767#discussion_r25375265
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -159,9 +159,11 @@ class DataFrame protected[sql](
/**
* Internal API for Python
+ * @param numRows Number of rows to show
*/
- private[sql] def showString(): String = {
- val data = take(20)
+ private[sql] def showString(numRows: Int = 20): String = {
+ val size = count()
--- End diff --
this forces the engine to read the data twice. why not just run take
directly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
