Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4602#discussion_r25382904
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -34,24 +35,12 @@ import org.apache.spark.sql.catalyst.expressions._
@DeveloperApi
case class Generate(
generator: Generator,
+ output: Seq[Attribute],
--- End diff --
Okay, but that sounds like an argument to take in only the produced
attributes as a parameter and have `output` be a def that is calculated based
on the value of `join`, etc. I don't see why we should keep the unused,
complicated, redundant `Attribute`s in generator (actually they are used once
in this file, but that seems like any easy way to allow these two things to get
out of sync)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
