maropu commented on a change in pull request #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r381958925
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -321,13 +315,13 @@ object DateTimeUtils {
}
}
- def instantToMicros(instant: Instant): Long = {
+ def instantToMicros(instant: Instant): SQLTimestamp = {
Review comment:
Ah, I see. What's the original reason to add this alias? Centainly, I feel
this kind of cosmetic aliases make the code hard to read somewhat. Any benefit
at the cost of at the expense of code readability?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
