MaxGekk commented on a change in pull request #27655: [SPARK-30897][SQL] The
behavior of ArrayExists should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27655#discussion_r382236805
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
##########
@@ -522,11 +522,14 @@ case class ArrayFilter(
since = "2.4.0")
case class ArrayExists(
argument: Expression,
- function: Expression)
+ function: Expression,
+ followThreeValuedLogic: Boolean)
extends ArrayBasedSimpleHigherOrderFunction with CodegenFallback {
- private val followThreeValuedLogic =
- SQLConf.get.getConf(SQLConf.LEGACY_ARRAY_EXISTS_FOLLOWS_THREE_VALUED_LOGIC)
+ def this(argument: Expression, function: Expression) = {
+ this(argument, function,
+
SQLConf.get.getConf(SQLConf.LEGACY_ARRAY_EXISTS_FOLLOWS_THREE_VALUED_LOGIC))
Review comment:
```scala
this(
argument,
function,
SQLConf.get.getConf(SQLConf.LEGACY_ARRAY_EXISTS_FOLLOWS_THREE_VALUED_LOGIC))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
