cloud-fan commented on a change in pull request #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table URL: https://github.com/apache/spark/pull/27597#discussion_r382410965
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ########## @@ -104,7 +105,13 @@ case class DataSourceAnalysis(conf: SQLConf) extends Rule[LogicalPlan] with Cast None } else if (potentialSpecs.size == 1) { val partValue = potentialSpecs.head._2 - Some(Alias(cast(Literal(partValue), field.dataType), field.name)()) + conf.storeAssignmentPolicy match { + case StoreAssignmentPolicy.ANSI | StoreAssignmentPolicy.STRICT => Review comment: yea let's add some comments ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org