cloud-fan commented on a change in pull request #27617: [SPARK-30865][SQL]
Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382413997
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -138,25 +129,25 @@ object DateTimeUtils {
* Converts the timestamp to milliseconds since epoch. In spark timestamp
values have microseconds
* precision, so this conversion is lossy.
*/
- def toMillis(us: SQLTimestamp): Long = {
+ def toMillis(us: Long): Long = {
// When the timestamp is negative i.e before 1970, we need to adjust the
millseconds portion.
// Example - 1965-01-01 10:11:12.123456 is represented as
(-157700927876544) in micro precision.
// In millis precision the above needs to be represented as
(-157700927877).
Math.floorDiv(us, MICROS_PER_MILLIS)
}
/*
- * Converts milliseconds since epoch to SQLTimestamp.
+ * Converts milliseconds since the epoch to microseconds.
*/
- def fromMillis(millis: Long): SQLTimestamp = {
+ def fromMillis(millis: Long): Long = {
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
