Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4767#discussion_r25408008
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
    @@ -441,4 +441,8 @@ class DataFrameSuite extends QueryTest {
         checkAnswer(df.select(df("key")), 
testData.select('key).collect().toSeq)
       }
     
    +  test("show") {
    +    testData.select($"*").show()
    --- End diff --
    
    actually this is a bad idea. it prints a lot of garbage to console. maybe 
we can ignore the test and add a comment saying this is ignored but we want to 
make sure it compiles correctly. do the same for java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to