cloud-fan commented on a change in pull request #27644: [SPARK-30868][SQL]
Throw Exception if runHive(sql) failed
URL: https://github.com/apache/spark/pull/27644#discussion_r382477219
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogSuite.scala
##########
@@ -154,4 +155,26 @@ class HiveExternalCatalogSuite extends
ExternalCatalogSuite {
catalog.createTable(hiveTable, ignoreIfExists = false)
assert(catalog.getTable("db1", "spark_29498").owner === owner)
}
+
+ test("SPARK-30868 throw an exception if HiveClient#runSqlHive fails") {
+ // test add jars which not exists
+ val jarPath = "file:///tmp/not_exists.jar"
+
assertThrows[QueryExecutionException](externalCatalog.client.runSqlHive(s"ADD
JAR $jarPath"))
+
+ // test change to the database which doesn't exists
+ assertThrows[QueryExecutionException](externalCatalog.client.runSqlHive(
+ s"use db_not_exists"))
+
+ // test create hive table failed
+ assertThrows[QueryExecutionException](externalCatalog.client.runSqlHive(
+ s"CREATE TABLE table_not_exists(n into)"))
Review comment:
make the comment clear that this is to test the wrong `into` type. The table
name probably doesn't matter and we can use `t`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
