beliefer commented on a change in pull request #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r382534334
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -61,6 +61,22 @@ grammar SqlBase;
* When true, the behavior of keywords follows ANSI SQL standard.
*/
public boolean SQL_standard_keyword_behavior = false;
+
+ /**
+ * This method will be called when we see '/*' and try to match it as a
bracketed comment.
+ * If the next character is '+', it should be parsed as hint later,
otherwise we cannot match
+ * it as a bracketed comment.
+ *
+ * Returns true if the first character is '+'.
Review comment:
My fault.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
