maropu commented on a change in pull request #27675: [SPARK-30870][SQL] Fix
nested column aliasing
URL: https://github.com/apache/spark/pull/27675#discussion_r382969363
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -129,7 +129,9 @@ object NestedColumnAliasing {
// If all nested fields of `attr` are used, we don't need to introduce
new aliases.
// By default, ColumnPruning rule uses `attr` already.
if (nestedFieldToAlias.nonEmpty &&
- nestedFieldToAlias.length < totalFieldNum(attr.dataType)) {
+ nestedFieldToAlias
+ .map { case (nestedField, _) =>
totalFieldNum(nestedField.dataType) }
+ .sum < totalFieldNum(attr.dataType)) {
Review comment:
Ur, I see. nice catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
