Github user advancedxy commented on the pull request:

    https://github.com/apache/spark/pull/4783#issuecomment-76190779
  
    @shivaram -- I followed the 
[JDK-8024912](https://bugs.openjdk.java.net/browse/JDK-8024912), 
[JDK-8024913](https://bugs.openjdk.java.net/browse/JDK-8024913) and 
[JDK-7007564](https://bugs.openjdk.java.net/browse/JDK-7007564), It looks like 
non-static field size is aligned to wordSize(8 bytes on 64bit JVM without 
UseCompressedOops, 4bytes otherwise, verified by the Sizeof code I mentioned on 
the jira). And the hotspot JVM wouldn't change that in short time.
    
    This is the hotspot version, and I have no ideas about other version's of 
JVM. But I think we can use this setting up for now just like we did with the 
ALIGN_SIZE? 
    
    And this is what I get for now. If we (including others or some JVM 
experts) can agree on that, I will update the code. So, waiting for others' 
opinion now 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to